Update maplibre-gl to 5.0 #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcjulian
approved these changes
Jan 6, 2025
| @@ -10,7 +10,7 @@ import { MapComponent, LayerComponent } from '@maplibre/ngx-maplibre-gl'; | |||
| " | |||
| [zoom]="[15]" | |||
| [center]="[-122.486052, 37.830348]" | |||
| [preserveDrawingBuffer]="true" | |||
| [canvasContextAttributes]="{preserveDrawingBuffer: true}" | |||
There was a problem hiding this comment.
Perhaps we could add this as breaking change to the changelog?
There was a problem hiding this comment.
Sure, except we don't really follow semver since we mainly follow angular versioning...
I also changed the changelog editing to be more automated so that only when trying to release a new version the changelog will be updated as part of the "bump version PR" workflow.
|
I'll be merging this now. We can continue the discussion here on how to release it, which addition the changelog needs and what version number we should give. |
birkskyum
approved these changes
Jan 6, 2025
|
I can try it in production once its released to npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add some missing attributes from the map options object and the navigation control.
The main changes are in the preserveDrawingBuffer, which was moved to an internal object.
Added projection settings as well.
Removed some noise in the console log of the unit-tests.
Added globe control directive and globe example.